Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32245 )
Change subject: mediatek: Use a 64-bit timer
......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/#/c/32245/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/32245/2//COMMIT_MSG@9
PS2, Line 9: will be overflow
… will overflow at …
https://review.coreboot.org/#/c/32245/2//COMMIT_MSG@11
PS2, Line 11: is overflow
overflows
https://review.coreboot.org/#/c/32245/2/src/soc/mediatek/common/timer.c
File src/soc/mediatek/common/timer.c:
https://review.coreboot.org/#/c/32245/2/src/soc/mediatek/common/timer.c@37
PS2, Line 37: ((uint64_t)high)
Are these () correct? What is supposed to be shifted?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32245
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9f080e47253a1b1bab4636a45cb86c8666a25302
Gerrit-Change-Number: 32245
Gerrit-PatchSet: 2
Gerrit-Owner: Tristan Hsieh
tristan.shieh@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Tristan Hsieh
tristan.shieh@mediatek.com
Gerrit-Reviewer: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 09 Apr 2019 09:22:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment