Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30281 )
Change subject: mb/google/hatch: Add EC trigger events and acpi configs
......................................................................
Patch Set 13:
(1 comment)
https://review.coreboot.org/#/c/30281/7/src/mainboard/google/hatch/variants/...
File src/mainboard/google/hatch/variants/baseboard/include/baseboard/ec.h:
https://review.coreboot.org/#/c/30281/7/src/mainboard/google/hatch/variants/...
PS7, Line 79: #endif /* __BASEBOARD_EC_H__ */
we can add the required changes in this CL itself and call it out in commit msg […]
Subrata, I would need the information on the form factor to know if the device would support the tablet mode and enable the TBMC support, updated the bug with query. I can cover the TBMC changes in another CL
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30281
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3a86f609c269cb59e546fc7ba4ba032e5ea8341a
Gerrit-Change-Number: 30281
Gerrit-PatchSet: 13
Gerrit-Owner: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 24 Dec 2018 06:05:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Comment-In-Reply-To: Aamir Bohra
aamir.bohra@intel.com
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment