Felix Held submitted this change.

View Change

Approvals: build bot (Jenkins): Verified Tim Wawrzynczak: Looks good to me, approved
mb/google/brya/var/redrix: Add new memory support

Add the new memory support:
Hynix H54G46CYRBX267
Samsung K4U6E3S4AB-MGCL
Hynix H54G56CYRBX247
Samsung K4UBE3D4AB-MGCL

BUG=b:212330664
TEST=FW_NAME=redrix emerge-brya coreboot

Change-Id: I32491f86813c8e6566774d4b3d7d82295f906bd3
Signed-off-by: Wisley Chen <wisley.chen@quanta.corp-partner.google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/60410
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
---
M src/mainboard/google/brya/variants/redrix/memory/Makefile.inc
M src/mainboard/google/brya/variants/redrix/memory/dram_id.generated.txt
M src/mainboard/google/brya/variants/redrix/memory/mem_parts_used.txt
M src/mainboard/google/brya/variants/redrix4es/memory/Makefile.inc
M src/mainboard/google/brya/variants/redrix4es/memory/dram_id.generated.txt
M src/mainboard/google/brya/variants/redrix4es/memory/mem_parts_used.txt
6 files changed, 24 insertions(+), 8 deletions(-)

diff --git a/src/mainboard/google/brya/variants/redrix/memory/Makefile.inc b/src/mainboard/google/brya/variants/redrix/memory/Makefile.inc
index 8590598..c023416 100644
--- a/src/mainboard/google/brya/variants/redrix/memory/Makefile.inc
+++ b/src/mainboard/google/brya/variants/redrix/memory/Makefile.inc
@@ -1,11 +1,11 @@
# SPDX-License-Identifier: GPL-2.0-or-later
# This is an auto-generated file. Do not edit!!
# Generated by:
-# util/spd_tools/bin/part_id_gen ADL lp4x src/mainboard/google/brya/variants/redrix/memory src/mainboard/google/brya/variants/redrix/memory/mem_parts_used.txt
+# ./util/spd_tools/lp4x/part_id_gen ADL lp4x src/mainboard/google/brya/variants/redrix/memory src/mainboard/google/brya/variants/redrix/memory/mem_parts_used.txt

SPD_SOURCES =
SPD_SOURCES += spd/lp4x/set-0/spd-4.hex # ID = 0(0b0000) Parts = MT53E1G32D2NP-046 WT:A
-SPD_SOURCES += spd/lp4x/set-0/spd-1.hex # ID = 1(0b0001) Parts = H9HCNNNBKMMLXR-NEE, K4U6E3S4AA-MGCR, MT53E512M32D2NP-046 WT:E, MT53E512M32D1NP-046 WT:B
-SPD_SOURCES += spd/lp4x/set-0/spd-3.hex # ID = 2(0b0010) Parts = H9HCNNNCPMMLXR-NEE, K4UBE3D4AA-MGCR, MT53E1G32D2NP-046 WT:B
+SPD_SOURCES += spd/lp4x/set-0/spd-1.hex # ID = 1(0b0001) Parts = H9HCNNNBKMMLXR-NEE, K4U6E3S4AA-MGCR, MT53E512M32D2NP-046 WT:E, MT53E512M32D1NP-046 WT:B, H54G46CYRBX267, K4U6E3S4AB-MGCL
+SPD_SOURCES += spd/lp4x/set-0/spd-3.hex # ID = 2(0b0010) Parts = H9HCNNNCPMMLXR-NEE, K4UBE3D4AA-MGCR, MT53E1G32D2NP-046 WT:B, H54G56CYRBX247, K4UBE3D4AB-MGCL
SPD_SOURCES += spd/lp4x/set-0/spd-2.hex # ID = 3(0b0011) Parts = H9HCNNNFAMMLXR-NEE
SPD_SOURCES += spd/lp4x/set-0/spd-7.hex # ID = 4(0b0100) Parts = MT53E2G32D4NQ-046 WT:A
diff --git a/src/mainboard/google/brya/variants/redrix/memory/dram_id.generated.txt b/src/mainboard/google/brya/variants/redrix/memory/dram_id.generated.txt
index 296634a..0349a4d 100644
--- a/src/mainboard/google/brya/variants/redrix/memory/dram_id.generated.txt
+++ b/src/mainboard/google/brya/variants/redrix/memory/dram_id.generated.txt
@@ -1,7 +1,7 @@
# SPDX-License-Identifier: GPL-2.0-or-later
# This is an auto-generated file. Do not edit!!
# Generated by:
-# util/spd_tools/bin/part_id_gen ADL lp4x src/mainboard/google/brya/variants/redrix/memory src/mainboard/google/brya/variants/redrix/memory/mem_parts_used.txt
+# ./util/spd_tools/lp4x/part_id_gen ADL lp4x src/mainboard/google/brya/variants/redrix/memory src/mainboard/google/brya/variants/redrix/memory/mem_parts_used.txt

DRAM Part Name ID to assign
MT53E1G32D2NP-046 WT:A 0 (0000)
@@ -14,3 +14,7 @@
MT53E2G32D4NQ-046 WT:A 4 (0100)
MT53E512M32D1NP-046 WT:B 1 (0001)
MT53E1G32D2NP-046 WT:B 2 (0010)
+H54G46CYRBX267 1 (0001)
+K4U6E3S4AB-MGCL 1 (0001)
+H54G56CYRBX247 2 (0010)
+K4UBE3D4AB-MGCL 2 (0010)
diff --git a/src/mainboard/google/brya/variants/redrix/memory/mem_parts_used.txt b/src/mainboard/google/brya/variants/redrix/memory/mem_parts_used.txt
index 71bd5fd..ca83c7f 100644
--- a/src/mainboard/google/brya/variants/redrix/memory/mem_parts_used.txt
+++ b/src/mainboard/google/brya/variants/redrix/memory/mem_parts_used.txt
@@ -8,3 +8,7 @@
MT53E2G32D4NQ-046 WT:A
MT53E512M32D1NP-046 WT:B
MT53E1G32D2NP-046 WT:B
+H54G46CYRBX267
+K4U6E3S4AB-MGCL
+H54G56CYRBX247
+K4UBE3D4AB-MGCL
diff --git a/src/mainboard/google/brya/variants/redrix4es/memory/Makefile.inc b/src/mainboard/google/brya/variants/redrix4es/memory/Makefile.inc
index 8590598..f9f2e5e 100644
--- a/src/mainboard/google/brya/variants/redrix4es/memory/Makefile.inc
+++ b/src/mainboard/google/brya/variants/redrix4es/memory/Makefile.inc
@@ -1,11 +1,11 @@
# SPDX-License-Identifier: GPL-2.0-or-later
# This is an auto-generated file. Do not edit!!
# Generated by:
-# util/spd_tools/bin/part_id_gen ADL lp4x src/mainboard/google/brya/variants/redrix/memory src/mainboard/google/brya/variants/redrix/memory/mem_parts_used.txt
+# ./util/spd_tools/lp4x/part_id_gen ADL lp4x src/mainboard/google/brya/variants/redrix4es/memory src/mainboard/google/brya/variants/redrix4es/memory/mem_parts_used.txt

SPD_SOURCES =
SPD_SOURCES += spd/lp4x/set-0/spd-4.hex # ID = 0(0b0000) Parts = MT53E1G32D2NP-046 WT:A
-SPD_SOURCES += spd/lp4x/set-0/spd-1.hex # ID = 1(0b0001) Parts = H9HCNNNBKMMLXR-NEE, K4U6E3S4AA-MGCR, MT53E512M32D2NP-046 WT:E, MT53E512M32D1NP-046 WT:B
-SPD_SOURCES += spd/lp4x/set-0/spd-3.hex # ID = 2(0b0010) Parts = H9HCNNNCPMMLXR-NEE, K4UBE3D4AA-MGCR, MT53E1G32D2NP-046 WT:B
+SPD_SOURCES += spd/lp4x/set-0/spd-1.hex # ID = 1(0b0001) Parts = H9HCNNNBKMMLXR-NEE, K4U6E3S4AA-MGCR, MT53E512M32D2NP-046 WT:E, MT53E512M32D1NP-046 WT:B, H54G46CYRBX267, K4U6E3S4AB-MGCL
+SPD_SOURCES += spd/lp4x/set-0/spd-3.hex # ID = 2(0b0010) Parts = H9HCNNNCPMMLXR-NEE, K4UBE3D4AA-MGCR, MT53E1G32D2NP-046 WT:B, H54G56CYRBX247, K4UBE3D4AB-MGCL
SPD_SOURCES += spd/lp4x/set-0/spd-2.hex # ID = 3(0b0011) Parts = H9HCNNNFAMMLXR-NEE
SPD_SOURCES += spd/lp4x/set-0/spd-7.hex # ID = 4(0b0100) Parts = MT53E2G32D4NQ-046 WT:A
diff --git a/src/mainboard/google/brya/variants/redrix4es/memory/dram_id.generated.txt b/src/mainboard/google/brya/variants/redrix4es/memory/dram_id.generated.txt
index 296634a..61cb7fd 100644
--- a/src/mainboard/google/brya/variants/redrix4es/memory/dram_id.generated.txt
+++ b/src/mainboard/google/brya/variants/redrix4es/memory/dram_id.generated.txt
@@ -1,7 +1,7 @@
# SPDX-License-Identifier: GPL-2.0-or-later
# This is an auto-generated file. Do not edit!!
# Generated by:
-# util/spd_tools/bin/part_id_gen ADL lp4x src/mainboard/google/brya/variants/redrix/memory src/mainboard/google/brya/variants/redrix/memory/mem_parts_used.txt
+# ./util/spd_tools/lp4x/part_id_gen ADL lp4x src/mainboard/google/brya/variants/redrix4es/memory src/mainboard/google/brya/variants/redrix4es/memory/mem_parts_used.txt

DRAM Part Name ID to assign
MT53E1G32D2NP-046 WT:A 0 (0000)
@@ -14,3 +14,7 @@
MT53E2G32D4NQ-046 WT:A 4 (0100)
MT53E512M32D1NP-046 WT:B 1 (0001)
MT53E1G32D2NP-046 WT:B 2 (0010)
+H54G46CYRBX267 1 (0001)
+K4U6E3S4AB-MGCL 1 (0001)
+H54G56CYRBX247 2 (0010)
+K4UBE3D4AB-MGCL 2 (0010)
diff --git a/src/mainboard/google/brya/variants/redrix4es/memory/mem_parts_used.txt b/src/mainboard/google/brya/variants/redrix4es/memory/mem_parts_used.txt
index 71bd5fd..ca83c7f 100644
--- a/src/mainboard/google/brya/variants/redrix4es/memory/mem_parts_used.txt
+++ b/src/mainboard/google/brya/variants/redrix4es/memory/mem_parts_used.txt
@@ -8,3 +8,7 @@
MT53E2G32D4NQ-046 WT:A
MT53E512M32D1NP-046 WT:B
MT53E1G32D2NP-046 WT:B
+H54G46CYRBX267
+K4U6E3S4AB-MGCL
+H54G56CYRBX247
+K4UBE3D4AB-MGCL

To view, visit change 60410. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I32491f86813c8e6566774d4b3d7d82295f906bd3
Gerrit-Change-Number: 60410
Gerrit-PatchSet: 4
Gerrit-Owner: Chen Wisley <wisley.chen@quantatw.com>
Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Wisley Chen <wisley.chen@quanta.corp-partner.google.com>
Gerrit-MessageType: merged