Attention is currently required from: Lance Zhao, Subrata Banik, Tim Wawrzynczak.
View Change
1 comment:
Patchset:
Patch Set #5:
LGTM […]
Thanks Subrata.
I can definately split into smaller changes. However, for example, this CL doesn't work correctly without the change to uart.c (path name lookups failed). Do we stil recommend splitting in those cases?
To view, visit change 63969. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibe46a0583c522a8adf0a015cd3a698f694482437
Gerrit-Change-Number: 63969
Gerrit-PatchSet: 5
Gerrit-Owner: Tarun Tuli <taruntuli@google.com>
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Subrata Banik <subratabanik@google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak@chromium.org>
Gerrit-Attention: Lance Zhao
Gerrit-Attention: Subrata Banik <subratabanik@google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak@chromium.org>
Gerrit-Comment-Date: Sat, 30 Apr 2022 18:56:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik <subratabanik@google.com>
Gerrit-MessageType: comment