Patch Set 14:

(3 comments)

Hmm... well... I'm still somewhat confused. Your patch changed behavior now. Previously you were reading the current value and subtracting 6, now you're just overwriting the value. I thought you were doing that because you didn't know what the existing calibration value was (e.g. it might be different per board and initialized from fuses or something), so you could only adjust the existing one.

But if you are sure that setting it directly is okay then this approach is fine.

Hi, Julius
I have a misunderstanding about the calibration of pmic mt6358 before and it is correct now.
I update the patch for your comments, please let me know if there is any problem.
Many thanks for your reviewing.

View Change

To view, visit change 32057. To unsubscribe, or for help writing mail filters, visit settings.