2 comments:
File src/mainboard/purism/librem_cnl/romstage.c:
nit: for clarity, maybe set this to `dimm_changed`. […]
IMO, that's actually less clear, and I don't want to diverge the implementation here and in google/hatch unnecessarily if we're going to end up unifying it at the SoC or common level
Patch Set #2, Line 104: cannonlake_memcfg_init(mem_cfg, &memcfg);
Wouldn't it make more sense to move the spd cache code into `cannonlake_memcfg_init`?
possibly, but one would at least need to pass in the channel config, SPD address map, etc. But open to ideas
To view, visit change 48549. To unsubscribe, or for help writing mail filters, visit settings.