Attention is currently required from: Furquan Shaikh, Paul Menzel, Julius Werner, Eric Peers.
View Change
2 comments:
Commit Message:
Patch Set #2, Line 29:
So is the tag below correct? […]
Maybe? Or maybe the one that added cpu_info. I've submitted so many CLs trying to get coop working, and haven't tagged them: https://review.coreboot.org/q/message:%2522b:179699789%2522
I can tag this one if you want though.
Patch Set #2, Line 32: executing the SIPI vector.
do we also need tests across both intel and amd?
I'm sure it would be reproducable in QEMU. I've never tried running it though.
The change uses plain vanilla x86, so there won't be a difference between Intel or AMD.
To view, visit change 57565. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9a89b5ccc781940dbc0e758c015db480f7cec944
Gerrit-Change-Number: 57565
Gerrit-PatchSet: 2
Gerrit-Owner: Raul Rangel <rrangel@chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Julius Werner <jwerner@chromium.org>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Aaron Durbin <adurbin@chromium.org>
Gerrit-CC: Eric Peers <epeers@google.com>
Gerrit-CC: Nikolai Vyssotski <nikolai.vyssotski@amd.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Furquan Shaikh <furquan@google.com>
Gerrit-Attention: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Julius Werner <jwerner@chromium.org>
Gerrit-Attention: Eric Peers <epeers@google.com>
Gerrit-Comment-Date: Thu, 16 Sep 2021 18:47:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter@mailbox.org>
Comment-In-Reply-To: Eric Peers <epeers@google.com>
Gerrit-MessageType: comment