[coreboot-gerrit] [S] Change in coreboot[master]: soc/intel/meteorlake: Validate CPU crashlog discovery table and records

[Jakub Czapiga (Code Review)]

Attention is currently required from: Kapil Porwal, Paul Menzel, Pratikkumar V Prajapati, Subrata Banik, Sumeet R Pawnikar, Tarun Tuli, Tracy Wu.

Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76333?usp=email )

Change subject: soc/intel/meteorlake: Validate CPU crashlog discovery table and records
......................................................................

Patch Set 13:

(3 comments)

File src/soc/intel/meteorlake/crashlog.c:

https://review.coreboot.org/c/coreboot/+/76333/comment/d8e6568c_72360cff :
PS13, Line 381: 0x%x
info-nit: You can use `%#x` instead of `0x%x`, or `%#X` instead of `%#X`.

https://review.coreboot.org/c/coreboot/+/76333/comment/49e47693_41626d3a :
PS13, Line 403: printk(BIOS_DEBUG, "cpu crashlog records already consumed."
              : 						"id: 0x%x dw0: 0x%x\n", i, dw0);
Message says `records` but only one ID is passed. Can you rephrase this message to inform that all records from this one ID are already consumed instead?

File src/soc/intel/meteorlake/include/soc/crashlog.h:

https://review.coreboot.org/c/coreboot/+/76333/comment/f1f5f303_07f4597d :
PS13, Line 21: 0x1
`(1 << 31)` should be enough here or you can use `BIT(31)` from `types.h` instead.