I will share the final changes with Mike to upload here. Can you please answer the query on indentation.
8 comments:
File src/soc/qualcomm/sdm845/i2c.c:
Patch Set #31, Line 44: struct qup_i2c_clk_fld *itr = qup_i2c_clk_map + idx;
When you rewrite this to use the generic enum (see other file), I'd write this stuff like this inste […]
Done
Patch Set #31, Line 89: (BITS_PER_WORD >> 4));
What about rewriting this to log2(BITS_PER_WORD) - 3? You said "Done" to that, but it looks like you […]
Sorry about it, I should've mentioned that changes are not yet shared here.
Patch Set #31, Line 130: segment.buf, segment.buf
Note that if you combine the three size parameters into one like I'm suggesting in the other file, y […]
Done
File src/soc/qualcomm/sdm845/include/soc/i2c.h:
Actually, looks like we have an existing enum for this in <device/i2c.h> (I2C_SPEED_FAST, etc. […]
Done
File src/soc/qualcomm/sdm845/qcom_qup_se.c:
Patch Set #31, Line 101: u32 wait_till_irq_set(unsigned int bus)
I think all of these functions other than qup_isr_handle() could be static? […]
Done, We want to export handle_error and wait_till_irq_set functions as well, I have renamed them as suggested.
Please fix indentation.
Similar indentation we use in our HLOS driver and it looks good to us. Not sure whether any fixed rule exists here to break a line having more than 80 characters. How do you suggest to indent here?
Patch Set #31, Line 184: qup_isr_handle
"ISR handle" sounds a bit weird for that this function actually does (which is handle a full transfe […]
Done
Patch Set #31, Line 185: unsigned int tx_rem_bytes, unsigned int rx_rem_bytes)
You shouldn't need to pass all of size, tx_rem_bytes and rx_rem_bytes. […]
Done
To view, visit change 29104. To unsubscribe, or for help writing mail filters, visit settings.