Patch set 1:Code-Review +2
3 comments:
Patch Set #1, Line 108: uses_address
Since this now means something else (it was used as a boolean before), maybe a rename or using an enum could improve clarity?
Patch Set #1, Line 250: address_mode
I've no idea, but should this be changed to `address_bytes`?
Patch Set #1, Line 281: if (spi_cmd_vals->uses_address) {
Sanity check: does this need to be updated?
To view, visit change 48584. To unsubscribe, or for help writing mail filters, visit settings.