Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37213 )
Change subject: [TESTONLY]nb/intel/x4x: Cache cbmem in romstage ......................................................................
Patch Set 7:
This on the ancestors
git fetch "https://review.coreboot.org/coreboot" refs/changes/13/37213/7 && git checkout FETCH_HEAD
correctly boot on the ASRock E350M1 (AMD Fusion, AGESA Family 14h)) and seem to save 9 ms according to the timestamps (but only did two boots comparing it to the results in the board status repository).
``` $ sudo cbmem -t 33 entries total:
0:1st timestamp 7,886 11:start of bootblock 13,453 (5,567) 12:end of bootblock 14,770 (1,317) 13:starting to load romstage 15,380 (609) 14:finished loading romstage 15,462 (81) 1:start of romstage 15,770 (308) 2:before ram initialization 127,956 (112,185) 3:after ram initialization 402,574 (274,617) 17:starting LZ4 decompress (ignore for x86) 414,089 (11,515) 18:finished LZ4 decompress (ignore for x86) 415,027 (937) 100:start of postcar 416,485 (1,458) 101:end of postcar 416,486 (0) 8:starting to load ramstage 416,596 (110) 15:starting LZMA decompress (ignore for x86) 416,632 (36) 16:finished LZMA decompress (ignore for x86) 507,218 (90,585) 9:finished loading ramstage 507,264 (46) 10:start of ramstage 507,286 (21) 30:device enumeration 511,203 (3,917) 40:device configuration 649,123 (137,920) 50:device enable 662,052 (12,928) 60:device initialization 662,521 (468) 65:Option ROM initialization 676,528 (14,007) 66:Option ROM copy done 708,377 (31,849) 67:Option ROM run done 750,088 (41,710) 70:device setup done 750,532 (443) 75:cbmem post 1,000,542 (250,010) 80:write tables 1,000,543 (1) 85:finalize chips 1,007,883 (7,340) 90:load payload 1,007,888 (4) 15:starting LZMA decompress (ignore for x86) 1,008,407 (519) 16:finished LZMA decompress (ignore for x86) 1,034,267 (25,860) 15:starting LZMA decompress (ignore for x86) 1,034,338 (70) 16:finished LZMA decompress (ignore for x86) 1,116,042 (81,703) 99:selfboot jump 1,116,134 (92)
Total Time: 1,108,233 ```