5 comments:
File src/soc/intel/common/block/pmc/pmc_ipc.c:
Patch Set #10, Line 112: FIELDLIST_NAMESTR("IWB3", 32), /* Write Buffer 3 */
I wonder if the results contained in the read buffer are ever worth keeping around? I see they weren't used in the .asl file, but does it provide additional status beyond the IERR bit?
Patch Set #10, Line 164: Local0
Local1
Should this be a #define in the .h file? So if the results of the IPCW call are needed elsehwere they can be referenced from here, same with error & timeout?
Patch Set #10, Line 181: Local0
Local1
Patch Set #10, Line 215: acpigen_write_integer
acpigen_write_dword? probably doesn't matter, it does know the write buffer fields are 32 bits wide.
To view, visit change 46259. To unsubscribe, or for help writing mail filters, visit settings.