[coreboot-gerrit] [L] Change in coreboot[main]: soc/mediatek/mt8196: Add DDP driver

[Nancy Lin (Code Review)]

Attention is currently required from: Hung-Te Lin, Jarried Lin, Paul Menzel, Yidi Lin, Yu-Ping Wu.

Nancy Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85950?usp=email )

Change subject: soc/mediatek/mt8196: Add DDP driver
......................................................................

Patch Set 4:

(3 comments)

File src/soc/mediatek/mt8196/ddp.c:

https://review.coreboot.org/c/coreboot/+/85950/comment/3ab9379c_e87d46a4?usp... :
PS3, Line 267: setbits32(&exdma2_reg->rdma_burst_ctl, BIT(28));
             : 	clrbits32(&exdma2_reg->rdma_burst_ctl, BIT(30));
             : 	setbits32(&exdma2_reg->rdma_burst_ctl, BIT(31));
             : 	setbits32(&exdma2_reg->dummy, BIT(2));
             : 	setbits32(&exdma2_reg->dummy, BIT(3));
             : 	setbits32(&exdma2_reg->datapath_con, BIT(0));
             : 	setbits32(&exdma2_reg->datapath_con, BIT(24));
             : 	setbits32(&exdma2_reg->datapath_con, BIT(25));
             : 	clrbits32(&exdma2_reg->ovl_mout, BIT(0));
             : 	setbits32(&exdma2_reg->ovl_mout, BIT(1));
> ok, I will fix it.

Done

https://review.coreboot.org/c/coreboot/+/85950/comment/0dcbbbd9_49c25220?usp... :
PS3, Line 312: 		printk(BIOS_WARNING, "%s: w/h: %d/%d exceed hw limit\n", __func__, width, height);
> ok, I will add it

Done

File src/soc/mediatek/mt8196/include/soc/addressmap.h:

https://review.coreboot.org/c/coreboot/+/85950/comment/215900ee_0491491b?usp... :
PS3, Line 198: MMSYS_MUTEX_BASE	= IO_PHYS + 0x22020000,
> OK, I will fix it

Done