
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35946 ) Change subject: pciexp: Support for allocating PCI express hotplug resources ...................................................................... Patch Set 2: (3 comments) https://review.coreboot.org/c/coreboot/+/35946/2/src/device/pci_device.c File src/device/pci_device.c: https://review.coreboot.org/c/coreboot/+/35946/2/src/device/pci_device.c@886 PS2, Line 886: } else else is not generally useful after a break or return https://review.coreboot.org/c/coreboot/+/35946/2/src/device/pci_device.c@886 PS2, Line 886: } else suspect code indent for conditional statements (24, 24) https://review.coreboot.org/c/coreboot/+/35946/2/src/device/pciexp_device.c File src/device/pciexp_device.c: https://review.coreboot.org/c/coreboot/+/35946/2/src/device/pciexp_device.c@... PS2, Line 500: printk(BIOS_DEBUG, "%s: add 0x%llx of prefetch memory space\n", __func__, resource->size); line over 96 characters -- To view, visit https://review.coreboot.org/c/coreboot/+/35946 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I500191626584b83e6a8ae38417fd324b5e803afc Gerrit-Change-Number: 35946 Gerrit-PatchSet: 2 Gerrit-Owner: Jeremy Soller <jeremy@system76.com> Gerrit-Reviewer: Jeremy Soller <jeremy@system76.com> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Aaron Durbin <adurbin@chromium.org> Gerrit-CC: Brandon Breitenstein <brandon.breitenstein@intel.com> Gerrit-CC: Divya S Sasidharan <divya.s.sasidharan@intel.com> Gerrit-CC: Duncan Laurie <dlaurie@chromium.org> Gerrit-CC: Felix Held <felix-coreboot@felixheld.de> Gerrit-CC: Furquan Shaikh <furquan@google.com> Gerrit-CC: Kyösti Mälkki <kyosti.malkki@gmail.com> Gerrit-CC: Matt DeVillier <matt.devillier@gmail.com> Gerrit-CC: Mimoja <coreboot@mimoja.de> Gerrit-CC: Nathaniel L Desimone <nathaniel.l.desimone@intel.com> Gerrit-CC: Nico Huber <nico.h@gmx.de> Gerrit-CC: Patrick Rudolph <patrick.rudolph@9elements.com> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-CC: Subrata Banik <subrata.banik@intel.com> Gerrit-Comment-Date: Thu, 05 Dec 2019 02:29:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment