[coreboot-gerrit] Change in coreboot[master]: pciexp: Support for allocating PCI express hotplug resources

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35946 )

Change subject: pciexp: Support for allocating PCI express hotplug resources
......................................................................


Patch Set 2:

(3 comments)

https://review.coreboot.org/c/coreboot/+/35946/2/src/device/pci_device.c 
File src/device/pci_device.c:

https://review.coreboot.org/c/coreboot/+/35946/2/src/device/pci_device.c@886 
PS2, Line 886: 			} else
else is not generally useful after a break or return


https://review.coreboot.org/c/coreboot/+/35946/2/src/device/pci_device.c@886 
PS2, Line 886: 			} else
suspect code indent for conditional statements (24, 24)


https://review.coreboot.org/c/coreboot/+/35946/2/src/device/pciexp_device.c 
File src/device/pciexp_device.c:

https://review.coreboot.org/c/coreboot/+/35946/2/src/device/pciexp_device.c@... 
PS2, Line 500: 	printk(BIOS_DEBUG, "%s: add 0x%llx of prefetch memory space\n", __func__, resource->size);
line over 96 characters



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/35946
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I500191626584b83e6a8ae38417fd324b5e803afc
Gerrit-Change-Number: 35946
Gerrit-PatchSet: 2
Gerrit-Owner: Jeremy Soller <[e-mail]>
Gerrit-Reviewer: Jeremy Soller <[e-mail]>
Gerrit-Reviewer: Martin Roth <[e-mail]>
Gerrit-Reviewer: Patrick Georgi <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Aaron Durbin <[e-mail]>
Gerrit-CC: Brandon Breitenstein <[e-mail]>
Gerrit-CC: Divya S Sasidharan <[e-mail]>
Gerrit-CC: Duncan Laurie <[e-mail]>
Gerrit-CC: Felix Held <[e-mail]>
Gerrit-CC: Furquan Shaikh <[e-mail]>
Gerrit-CC: Kyösti Mälkki <[e-mail]>
Gerrit-CC: Matt DeVillier <[e-mail]>
Gerrit-CC: Mimoja <[e-mail]>
Gerrit-CC: Nathaniel L Desimone <[e-mail]>
Gerrit-CC: Nico Huber <[e-mail]>
Gerrit-CC: Patrick Rudolph <[e-mail]>
Gerrit-CC: Paul Menzel <[e-mail]>
Gerrit-CC: Subrata Banik <[e-mail]>
Gerrit-Comment-Date: Thu, 05 Dec 2019 02:29:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment