Felix Held merged this change.
src/soc/intel/skylake/bootblock: Add SPT C236 to PCH Table
Add Skylake C236 to the PCH Table. The one which was already in there is
actually the CM236 and not the C236. This can be checked in datasheet:
100-series-chipset-datasheet-vol-1 p. 25.
Change-Id: I435927f15e9d3219886375426b09c68632dfe3d9
Signed-off-by: Christian Walter <christian.walter@9elements.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/33248
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
---
M src/include/device/pci_ids.h
M src/soc/intel/common/block/lpc/lpc.c
M src/soc/intel/skylake/bootblock/report_platform.c
3 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/src/include/device/pci_ids.h b/src/include/device/pci_ids.h
index fd90396..dae5c9a 100644
--- a/src/include/device/pci_ids.h
+++ b/src/include/device/pci_ids.h
@@ -2696,8 +2696,8 @@
#define PCI_DEVICE_ID_INTEL_SPT_H_Q170 0xa146
#define PCI_DEVICE_ID_INTEL_SPT_H_Q150 0xa147
#define PCI_DEVICE_ID_INTEL_SPT_H_B150 0xa148
-#define PCI_DEVICE_ID_INTEL_KBP_H_C236 0xa149
-#define PCI_DEVICE_ID_INTEL_SPT_H_C236 0xa150
+#define PCI_DEVICE_ID_INTEL_SPT_H_C236 0xa149
+#define PCI_DEVICE_ID_INTEL_SPT_H_CM236 0xa150
#define PCI_DEVICE_ID_INTEL_SPT_H_PREMIUM 0xa14e
#define PCI_DEVICE_ID_INTEL_SPT_H_H110 0xa143
#define PCI_DEVICE_ID_INTEL_SPT_H_QM170 0xa14d
diff --git a/src/soc/intel/common/block/lpc/lpc.c b/src/soc/intel/common/block/lpc/lpc.c
index 86547a4..84471d2 100644
--- a/src/soc/intel/common/block/lpc/lpc.c
+++ b/src/soc/intel/common/block/lpc/lpc.c
@@ -124,8 +124,8 @@
PCI_DEVICE_ID_INTEL_SPT_LP_U_BASE,
PCI_DEVICE_ID_INTEL_SPT_LP_U_PREMIUM,
PCI_DEVICE_ID_INTEL_SPT_LP_Y_PREMIUM,
+ PCI_DEVICE_ID_INTEL_SPT_H_CM236,
PCI_DEVICE_ID_INTEL_SPT_H_C236,
- PCI_DEVICE_ID_INTEL_KBP_H_C236,
PCI_DEVICE_ID_INTEL_SPT_H_PREMIUM,
PCI_DEVICE_ID_INTEL_SPT_H_H110,
PCI_DEVICE_ID_INTEL_SPT_H_H170,
diff --git a/src/soc/intel/skylake/bootblock/report_platform.c b/src/soc/intel/skylake/bootblock/report_platform.c
index e201a0a..6733f91 100644
--- a/src/soc/intel/skylake/bootblock/report_platform.c
+++ b/src/soc/intel/skylake/bootblock/report_platform.c
@@ -80,6 +80,7 @@
{ PCI_DEVICE_ID_INTEL_SPT_H_Q170, "Skylake PCH-H Q170" },
{ PCI_DEVICE_ID_INTEL_SPT_H_Q150, "Skylake PCH-H Q150" },
{ PCI_DEVICE_ID_INTEL_SPT_H_B150, "Skylake PCH-H B150" },
+ { PCI_DEVICE_ID_INTEL_SPT_H_CM236, "Skylake PCH-H CM236" },
{ PCI_DEVICE_ID_INTEL_SPT_H_C236, "Skylake PCH-H C236" },
{ PCI_DEVICE_ID_INTEL_SPT_H_QM170, "Skylake PCH-H QM170" },
{ PCI_DEVICE_ID_INTEL_SPT_H_HM175, "Skylake PCH-H HM175" },
To view, visit change 33248. To unsubscribe, or for help writing mail filters, visit settings.