Attention is currently required from: Angel Pons, Arthur Heymans, Jérémy Compostella, Karthik Ramasubramanian, Paul Menzel, Simon Glass, Stefan Reinauer.
View Change
1 comment:
Patchset:
Patch Set #10:
haven't really gotten around looking at the code, but thought a bit more about a possible clean implementation that doesn't add some parallel infrastructure or is too hacky and the two options is see are a file in cbfs and using an fmap section for this; the latter will be sort-of equivalent to the fixed flash location approach, but integrates way better into coreboot. when using an fmap section you'll get a fixed position in flash which you can use in the code by including <fmap_config.h> which gets generated during the build. the contents of that section can then just be put in there during build
To view, visit change 77712. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I04e946b33035a493e833500351a0483761252613
Gerrit-Change-Number: 77712
Gerrit-PatchSet: 10
Gerrit-Owner: Simon Glass <sjg@chromium.org>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit@felixsinger.de>
Gerrit-Reviewer: Julius Werner <jwerner@chromium.org>
Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella@intel.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub@google.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer@coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus@gmail.com>
Gerrit-CC: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-CC: Felix Held <felix-coreboot@felixheld.de>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-CC: Simon Glass <sjg@chromium.org>
Gerrit-Attention: Jérémy Compostella <jeremy.compostella@intel.com>
Gerrit-Attention: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer@coreboot.org>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Attention: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Attention: Simon Glass <sjg@chromium.org>
Gerrit-Attention: Karthik Ramasubramanian <kramasub@google.com>
Gerrit-Comment-Date: Thu, 08 Feb 2024 16:43:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment