Patch Set 1:

Patch Set 1:

Does XHCI work with this change too? Have you checked with USB3.0 when XHCI firmware is loaded?

I booted with this change applied and CONFIG_HUDSON_XHCI_ENABLE=y and it seems it's working correctly.

cbmem -c | grep XHCI

XHCI init on dev 00:10.0: regs @ 0xf0a68000, 4 ports, 32 slots, 32 byte contexts
XHCI extcap 0x1 @ 0xf0a68500
XHCI protocol USB 3.00, 2 ports (offset 1), def 0
XHCI protocol USB 2.00, 2 ports (offset 3), def 18
XHCI extcap 0xa @ 0xf0a68540
XHCI port #4: 0x00200e03, powered, enabled, pls 0, speed 3 [High]


dmesg | grep xHCI

[ 2.878740] xhci_hcd 0000:00:10.0: xHCI Host Controller
[ 2.987069] usb usb5: Product: xHCI Host Controller
[ 2.987458] xhci_hcd 0000:00:10.0: xHCI Host Controller
[ 2.990215] usb usb6: Product: xHCI Host Controller

[ 243.487821] usb 6-2: USB disconnect, device number 12
[ 254.889968] usb 6-2: new SuperSpeed USB device number 13 using xhci_hcd
[ 254.922795] usb 6-2: New USB device found, idVendor=13fe, idProduct=5500
[ 254.922802] usb 6-2: New USB device strings: Mfr=1, Product=2, SerialNumber=3
[ 254.922807] usb 6-2: Product: Patriot Memory

Did you also test an actual device, and run some speed tests? (To find data corruption, it’s good to have a file system with checksumming support (like Btrfs), then you get notified, if data corruption happens.)

Anyway, Mike, please update the commit message accordingly.

View Change

To view, visit change 38241. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I50a773eeab890627abc963e0a61f781d1cea3259
Gerrit-Change-Number: 38241
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Banon <mikebdp2@gmail.com>
Gerrit-Reviewer: Elisenda <lists@e4l.es>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski@3mdeb.com>
Gerrit-Reviewer: Mike Banon <mikebdp2@gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Wed, 08 Jan 2020 16:07:51 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment