Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46409 )
Change subject: soc/mediatek/mt8192: eint: unmask eint event mask register ......................................................................
Patch Set 6:
(5 comments)
https://review.coreboot.org/c/coreboot/+/46409/6//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46409/6//COMMIT_MSG@2 PS6, Line 2: gtk_pangao Please use G. Pangao.
https://review.coreboot.org/c/coreboot/+/46409/6//COMMIT_MSG@9 PS6, Line 9: need need to
https://review.coreboot.org/c/coreboot/+/46409/6//COMMIT_MSG@10 PS6, Line 10: it.upstream Please add a space after the dot/period.
https://review.coreboot.org/c/coreboot/+/46409/6//COMMIT_MSG@11 PS6, Line 11: with othe IC. Please elaborate. Do you mean coreboot upstream? What design differences are there?
https://review.coreboot.org/c/coreboot/+/46409/6//COMMIT_MSG@11 PS6, Line 11: othe other