Furquan Shaikh submitted this change.

View Change

Approvals: build bot (Jenkins): Verified EricR Lai: Looks good to me, approved Kangheui Won: Looks good to me, approved
mb/google/zork/var/vilboz: Update WiFi SAR for Vilboz/Vilboz360 LTE

Loading wifi_sar-vilboz-2.hex for vilboz LTE sku.
Loading wifi_sar-vilboz-3.hex for vilboz360 LTE sku.

BUG=b:183902165, b:176211194, b:183913210
BRANCH=firmware-zork-13434.B
TEST=Build coreboot and load the wifi sar table by fw_config

Signed-off-by: Frank Wu <frank_wu@compal.corp-partner.google.com>
Change-Id: I37a40456970e3f1dc8b2eed26aa23e3d75748222
Reviewed-on: https://review.coreboot.org/c/coreboot/+/51935
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Kangheui Won <khwon@chromium.org>
Reviewed-by: EricR Lai <ericr_lai@compal.corp-partner.google.com>
---
M src/mainboard/google/zork/variants/vilboz/variant.c
1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/src/mainboard/google/zork/variants/vilboz/variant.c b/src/mainboard/google/zork/variants/vilboz/variant.c
index 5006b92..43ca0e5 100644
--- a/src/mainboard/google/zork/variants/vilboz/variant.c
+++ b/src/mainboard/google/zork/variants/vilboz/variant.c
@@ -64,7 +64,6 @@
| |Vilboz|Vilboz14|Vilboz14|Vilboz|NA|Vilboz360|NA|Vilboz360|
| |WiFi |WiFi |LTE |LTE | |WiFi | |LTE |
+----------+------+--------+--------+------+--+---------+--+---------+
-|SAR[26] |0 |0 |0 |0 |0 |0 |0 |0 |
|SAR[25] |0 |0 |0 |0 |1 |1 |1 |1 |
|SAR[24] |0 |0 |1 |1 |0 |0 |1 |1 |
|SAR[23] |0 |1 |0 |1 |0 |1 |0 |1 |
@@ -83,14 +82,11 @@
case 1:
return "wifi_sar-vilboz-0.hex";
case 3:
- /*
- TODO: Set default first. It will be replaced after the
- new table is generated.
- */
- return WIFI_SAR_CBFS_DEFAULT_FILENAME;
+ return "wifi_sar-vilboz-2.hex";
case 5:
- case 7:
return "wifi_sar-vilboz-1.hex";
+ case 7:
+ return "wifi_sar-vilboz-3.hex";
default:
return WIFI_SAR_CBFS_DEFAULT_FILENAME;
}

To view, visit change 51935. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I37a40456970e3f1dc8b2eed26aa23e3d75748222
Gerrit-Change-Number: 51935
Gerrit-PatchSet: 3
Gerrit-Owner: Frank Wu <frank_wu@compal.corp-partner.google.com>
Gerrit-Reviewer: Eric Peers <epeers@google.com>
Gerrit-Reviewer: EricR Lai <ericr_lai@compal.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Isaac Lee <isaaclee@google.com>
Gerrit-Reviewer: Kangheui Won <khwon@chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Alan Lee <alan_lee@compal.corp-partner.google.com>
Gerrit-CC: John Su <john_su@compal.corp-partner.google.com>
Gerrit-MessageType: merged