8 comments:
File Documentation/getting_started/new_mainboard_ports.md:
Patch Set #4, Line 3: mainboards
singular 'mainboard'
Done
Patch Set #4, Line 7: It provides
"It generally provides"? For example the AMD Picasso code won't be getting SPDs since memory is alr […]
Done
Try to find out as much as possible about the current hardware.
Dump information with existing tools:
* lspci
* lsusb
* superiotool
* inteltool
* ectool
* dmidecode
* acpidump
Maybe "guard" this with an "if you are retrofitting coreboot to a mainboard which already has a work […]
Done
5. Be able to recover from a bad flash. You should use external flashing as
it's likely that you will brick your platform on the first attempts.
Make sure to backup the original firmware (if any).
IMHO, this should be the first thing. […]
Done
Patch Set #4, Line 53: scheme instead.
I would prefer to tell somebody to use the variants mechanism, than to have them undo the variants b […]
Done
Patch Set #4, Line 54: logical
should be an adverb: logically
Done
Patch Set #4, Line 56: Provide good documentation, see point 4
Maybe "Provide good documentation when possible. […]
Done
Patch Set #4, Line 74: You must own the Copyright
Thank you. Maybe: […]
Done
To view, visit change 34632. To unsubscribe, or for help writing mail filters, visit settings.