Patrick Georgi submitted this change.

View Change

Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, but someone else must approve Tim Wawrzynczak: Looks good to me, approved Mark Hsieh: Looks good to me, but someone else must approve
mb/google/volteer/variants/eldrid: Include SPD for MT40A512M16TB-062E:R

Add SPD support to eldrid for DDR4 memory part MT40A512M16TB-062E:R.

Eldrid should use DRAM_ID strap ID 0 (0000) on SKUs populated
with MT40A512M16TB-062E:R DDR4 memory parts.

BUG=b:192380070
TEST="FW_NAME=eldrid emerge-volteer coreboot" and verify it builds
successfully.

Signed-off-by: Mark Hsieh <mark_hsieh@wistron.corp-partner.google.com>
Change-Id: I4d07727c9c41bf494fbef373abce0ac1fc65c316
Reviewed-on: https://review.coreboot.org/c/coreboot/+/55983
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
---
M src/mainboard/google/volteer/variants/eldrid/memory/Makefile.inc
M src/mainboard/google/volteer/variants/eldrid/memory/dram_id.generated.txt
M src/mainboard/google/volteer/variants/eldrid/memory/mem_list_variant.txt
3 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/mainboard/google/volteer/variants/eldrid/memory/Makefile.inc b/src/mainboard/google/volteer/variants/eldrid/memory/Makefile.inc
index b2ab8ca..7fedb42 100644
--- a/src/mainboard/google/volteer/variants/eldrid/memory/Makefile.inc
+++ b/src/mainboard/google/volteer/variants/eldrid/memory/Makefile.inc
@@ -2,7 +2,7 @@
## This is an auto-generated file. Do not edit!!

SPD_SOURCES =
-SPD_SOURCES += ddr4-spd-1.hex # ID = 0(0b0000) Parts = H5AN8G6NDJR-XNC, K4A8G165WC-BCWE
+SPD_SOURCES += ddr4-spd-1.hex # ID = 0(0b0000) Parts = H5AN8G6NDJR-XNC, K4A8G165WC-BCWE, MT40A512M16TB-062E:R
SPD_SOURCES += ddr4-spd-1.hex # ID = 1(0b0001) Parts = MT40A512M16TB-062E:J
SPD_SOURCES += ddr4-spd-2.hex # ID = 2(0b0010) Parts = H5ANAG6NCMR-XNC
SPD_SOURCES += ddr4-spd-7.hex # ID = 3(0b0011) Parts = K4AAG165WA-BCWE, MT40A1G16KD-062E:E
diff --git a/src/mainboard/google/volteer/variants/eldrid/memory/dram_id.generated.txt b/src/mainboard/google/volteer/variants/eldrid/memory/dram_id.generated.txt
index 3b5315a..4b316d0 100644
--- a/src/mainboard/google/volteer/variants/eldrid/memory/dram_id.generated.txt
+++ b/src/mainboard/google/volteer/variants/eldrid/memory/dram_id.generated.txt
@@ -7,3 +7,4 @@
MT40A1G16KD-062E:E 3 (0011)
H5ANAG6NCJR-XNC 4 (0100)
K4AAG165WB-BCWE 4 (0100)
+MT40A512M16TB-062E:R 0 (0000)
diff --git a/src/mainboard/google/volteer/variants/eldrid/memory/mem_list_variant.txt b/src/mainboard/google/volteer/variants/eldrid/memory/mem_list_variant.txt
index 7a8cdf8..851a7a8 100644
--- a/src/mainboard/google/volteer/variants/eldrid/memory/mem_list_variant.txt
+++ b/src/mainboard/google/volteer/variants/eldrid/memory/mem_list_variant.txt
@@ -6,3 +6,4 @@
MT40A1G16KD-062E:E
H5ANAG6NCJR-XNC
K4AAG165WB-BCWE
+MT40A512M16TB-062E:R

To view, visit change 55983. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4d07727c9c41bf494fbef373abce0ac1fc65c316
Gerrit-Change-Number: 55983
Gerrit-PatchSet: 2
Gerrit-Owner: Mark Hsieh <mark_hsieh@wistron.corp-partner.google.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Caveh Jalali <caveh@chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Mark Hsieh <mark_hsieh@wistron.corp-partner.google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro@google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Anfernee Chen <anfernee_chen@wistron.corp-partner.google.com>
Gerrit-CC: Ariel Fang <ariel_fang@wistron.corp-partner.google.com>
Gerrit-CC: Casper Chang <casper_chang@wistron.corp-partner.google.com>
Gerrit-CC: Malik Hsu <malik_hsu@wistron.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-CC: Scott Chao <scott_chao@wistron.corp-partner.google.com>
Gerrit-CC: Terry Chen <terry_chen@wistron.corp-partner.google.com>
Gerrit-MessageType: merged