Patch Set 2:

Patch Set 2: Code-Review-1

Other programs including coreboot itself rely on "config" and "revision" without a prefix.

I have checked access to CBFS from the following APIs:

soc/intel/common/block/cpu/car/cache_as_ram_fsp.S
commonlib/cbfs.c
lib/cbfs.c cbfs.*load.*()

but did not find any uses of "config" or "revision". I could argue that only one of fallback or normal gets these files, and that therefore the other could get a prefix, but I would rather understand any consumers of these files from CBFS to see if this proposal still makes sense.

Can anyone point me to consumers of these files?

I found it used in src/mainboard/facebook/fbg1701/board_mboot.h and util/board_status/board_status.sh. It's possible some external programs rely on it, so you'd better send out a warning on the mailing list.

View Change

To view, visit change 42028. To unsubscribe, or for help writing mail filters, visit settings.