Patrick Georgi submitted this change.

View Change

Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Karthik Ramasubramanian: Looks good to me, approved
mb/google/dedede/var/boten: route GPP_E11 via APIC

GPP_E11 should be configured to be routed via APIC to avoid
p-sensor communication error in OS.

BUG=b:178465379
BRANCH=dedede
TEST=run "i2cdump -y -f 15 0x28" to confirm registers as expected.
un-approach:
=> register address: 0x01 value: 0x00
approach:
=> register address: 0x01 value: 0x02
verify sx932x IRQ in "/proc/interrupts" loading as expected.

Change-Id: I7d639ec1f9b31b240475dc1c8025bf59ae1e8e0b
Signed-off-by: Stanley Wu <stanley1.wu@lcfc.corp-partner.google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/50876
Reviewed-by: Karthik Ramasubramanian <kramasub@google.com>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
---
M src/mainboard/google/dedede/variants/boten/gpio.c
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/mainboard/google/dedede/variants/boten/gpio.c b/src/mainboard/google/dedede/variants/boten/gpio.c
index ee3a4e3..6046acb 100644
--- a/src/mainboard/google/dedede/variants/boten/gpio.c
+++ b/src/mainboard/google/dedede/variants/boten/gpio.c
@@ -48,7 +48,7 @@
/* E2 : CLK_24M_WCAM */
PAD_NC(GPP_E2, NONE),
/* E11 : AP_I2C_SUB_INT_ODL */
- PAD_CFG_GPI_INT(GPP_E11, NONE, PLTRST, EDGE_BOTH),
+ PAD_CFG_GPI_APIC(GPP_E11, NONE, PLTRST, LEVEL, NONE),

/* H6 : AP_I2C_CAM_SDA */
PAD_NC(GPP_H6, NONE),

To view, visit change 50876. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7d639ec1f9b31b240475dc1c8025bf59ae1e8e0b
Gerrit-Change-Number: 50876
Gerrit-PatchSet: 3
Gerrit-Owner: Stanley Wu <stanley1.wu@lcfc.corp-partner.google.com>
Gerrit-Reviewer: Henry Sun <henrysun@google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub@google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Paul Fagerburg <pfagerburg@chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Kevin Chang <kevin.chang@lcfc.corp-partner.google.com>
Gerrit-CC: Peichao Wang <pwang12@lenovo.corp-partner.google.com>
Gerrit-CC: Rasheed Hsueh <rasheed.hsueh@lcfc.corp-partner.google.com>
Gerrit-CC: Sunshine Chao <sunshine.chao@lcfc.corp-partner.google.com>
Gerrit-MessageType: merged