2 comments:
File src/northbridge/intel/common/mchbar_ops.h:
Patch Set #13, Line 20: #endif
We can just move the MCHBAR location to Kconfig?
Patch Set #13, Line 88: __always_inline void mchbar8_set(unsigned int offset, u8 set)
Ugh, apologies. I just realized that the `mchbarX_set` name is very misleading: […]
Slow down please. With macros instead of functions we'd lose the typing
again. Making it impossible for the compiler to detect real overflows. We
can use clrsetbitsXX() in the function bodies, ofc. (__versions are not to
be used outside the file that defines them, and wouldn't be necessary.)
`clrsetbits` is against our style, IMHO. It should be `clr_set_bits`.
To view, visit change 45517. To unsubscribe, or for help writing mail filters, visit settings.