Attention is currently required from: Lance Zhao, Maulik V Vaghela, Paul Menzel, Meera Ravindranath, Subrata Banik, Archana Patni, Michael Niewöhner, Ronak Kanabar.
Patch set 2:Code-Review +1
View Change
3 comments:
Commit Message:
Patch Set #2, Line 8:
Please describe the problem. […]
When entering S0ix states, when the PM timer is enabled, the system is unable to enter S0i3 (PM timer off is required for S0i3 entry).
Patch Set #2, Line 9:
ACPI PM timer needs to be disabled explicitly in CB to increment S0i3
counter as FSP has no control to do the same since
suggestion:
I would state this more like
```
Keeping the PM timer being enabled will disqualify an ADL system
from entering S0i3, and will also cause an increase in power
during suspend states. The PM timer is not required for brya
boards, therefore disable it.
```
Patch Set #2, Line 14: TEST=Boot gimble to OS and verify S0i3 counter incrementing
How can this be verified?
After exiting S0ix suspend state,
`cat /sys/kernel/debug/pmc_core/substate_residencies`
will show S0i3 residency and not S0i2
To view, visit change 59790. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8005dacd732c033980ccc479375ff5b06df8dac1
Gerrit-Change-Number: 59790
Gerrit-PatchSet: 2
Gerrit-Owner: Meera Ravindranath <meera.ravindranath@intel.com>
Gerrit-Reviewer: Archana Patni <archana.patni@intel.com>
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela@intel.com>
Gerrit-Reviewer: Michael Niewöhner <foss@mniewoehner.de>
Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar@intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik@intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Lance Zhao
Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela@intel.com>
Gerrit-Attention: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Meera Ravindranath <meera.ravindranath@intel.com>
Gerrit-Attention: Subrata Banik <subrata.banik@intel.com>
Gerrit-Attention: Archana Patni <archana.patni@intel.com>
Gerrit-Attention: Michael Niewöhner <foss@mniewoehner.de>
Gerrit-Attention: Ronak Kanabar <ronak.kanabar@intel.com>
Gerrit-Comment-Date: Wed, 01 Dec 2021 17:32:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Paul Menzel <paulepanter@mailbox.org>
Gerrit-MessageType: comment