Attention is currently required from: Felix Singer, Lance Zhao, Nico Huber, Furquan Shaikh, Tim Wawrzynczak, Paul Menzel, Angel Pons, Subrata Banik, Patrick Rudolph.
View Change
1 comment:
Patchset:
Patch Set #4:
We already had a discussion (CB:45000) on that topic but I need to bring that up once again.
AIUI timer emulation redirects (traps) all read/writes to the ACPI timer to the emulation. uCode emulates everything except a) TCO timer, which does not work without the hw timer and b) TMR_STS, which is used to generate timer overflow interrupts.
When both HW timer and uCode timer are enabled the OS/OSPM can never use the hw timer. However, when the TCO gets used and for some reason TMR_STS generates an interrupt, I have no idea what happens then. I don't even know if that's possible.
My suggestion is to disable timer emulation when the hw timer is present/enabled, since having both does not have any advantage.
To view, visit change 57930. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I60a775bd6eb4206750f606ce8a8777d2e2dfb579
Gerrit-Change-Number: 57930
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Niewöhner <foss@mniewoehner.de>
Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Reviewer: Subrata Banik <subrata.banik@intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <inforichland@gmail.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Felix Singer <felixsinger@posteo.net>
Gerrit-Attention: Lance Zhao
Gerrit-Attention: Nico Huber <nico.h@gmx.de>
Gerrit-Attention: Furquan Shaikh <furquan@google.com>
Gerrit-Attention: Tim Wawrzynczak <inforichland@gmail.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak@chromium.org>
Gerrit-Attention: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Attention: Subrata Banik <subrata.banik@intel.com>
Gerrit-Attention: Patrick Rudolph <siro@das-labor.org>
Gerrit-Comment-Date: Sat, 25 Sep 2021 22:51:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment