I'm seeing an issue where zero-brightness (Backlight off) is being treated as full brightness. So instead of turning off the backlight when the lid is closed, it's set to max.

Tested with patchset 12 on master @ e2f5fb25

View Change

To view, visit change 28950. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0355d39a61956792e69bccd5274cfc2749d72bf0
Gerrit-Change-Number: 28950
Gerrit-PatchSet: 12
Gerrit-Owner: Alexander Couzens <lynxis@fe80.eu>
Gerrit-Reviewer: Alexander Couzens <lynxis@fe80.eu>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Reviewer: Kilian Neuner <cb@9-r.net>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: Peter Lemenkov <lemenkov@gmail.com>
Gerrit-Reviewer: Richard Slindee
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Felix Singer <felixsinger@posteo.net>
Gerrit-CC: Aleksei Kharlamov <derlafff@ya.ru>
Gerrit-CC: Christian Herzog
Gerrit-CC: Holger Levsen <holger@layer-acht.org>
Gerrit-CC: Matthias Wiedhalm
Gerrit-CC: Pavel Kovalenko <su@nitrocaster.me>
Gerrit-CC: Sergey Alirzaev <zl29ah@gmail.com>
Gerrit-CC: Tom Hiller <thrilleratplay@gmail.com>
Gerrit-CC: Tomasz Jan Góralczyk
Gerrit-CC: clayton craft
Gerrit-CC: slact
Gerrit-Comment-Date: Mon, 03 Aug 2020 04:02:24 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment