Arthur Heymans uploaded patch set #18 to this change.

View Change

drivers/smmstore: Fix some issues

This fixes the following:
- Fix smmstore_read_region to actually read stuff
- Clean up the code a little
- Change the loglevel for non error messages to BIOS_DEBUG
- Use an incoherent rdev to potentially speed up reading access

TESTED on google/wolf with out of tree patch to hook up smmstore to

Change-Id: I629be25d2a9b65796ae8f7a700b6bdab57b91b22
Signed-off-by: Arthur Heymans <>
M src/drivers/smmstore/store.c
1 file changed, 104 insertions(+), 64 deletions(-)

git pull ssh:// refs/changes/32/30432/18

To view, visit change 30432. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I629be25d2a9b65796ae8f7a700b6bdab57b91b22
Gerrit-Change-Number: 30432
Gerrit-PatchSet: 18
Gerrit-Owner: Arthur Heymans <>
Gerrit-Assignee: Aaron Durbin <>
Gerrit-Reviewer: Aaron Durbin <>
Gerrit-Reviewer: Arthur Heymans <>
Gerrit-Reviewer: Matt DeVillier <>
Gerrit-Reviewer: Matthew Garrett <>
Gerrit-Reviewer: Patrick Georgi <>
Gerrit-Reviewer: Patrick Rudolph <>
Gerrit-Reviewer: build bot (Jenkins) <>
Gerrit-CC: Paul Menzel <>
Gerrit-MessageType: newpatchset