View Change

4 comments:

• Commit Message:

  • Patch Set #2, Line 21: Signed-off-by

    you could ditch one of these lines.

    Ack

• File src/soc/amd/picasso/acpi.c:

  • Patch Set #2, Line 55: 0 - max logical cpus - 1

    This reads as 0 - max logical cpus. i.e., a negative number. […]

    Ack

  • Patch Set #2, Line 64: nb_ioapic_base

    you'll need to mask off some of the lower bits

    Ack

• File src/soc/amd/picasso/acpi.c:

  • Patch Set #5, Line 59: CONFIG_MAX_CPUS

    I think we should do one of two things: […]

    Agree. We are planning a separate change to add a upd so coreboot can dictate what ids it wants to use.

To view, visit change 45056. To unsubscribe, or for help writing mail filters, visit settings.