4 comments:
* Modes:
* -2 = GP-Out
* -1 = GP-In
* 0 = Undefined
* >0 = Native functions
this should be an `enum`.
Ack
uint32_t config0;
uint32_t config1;
So these would be used to cache the register content for later processing? […]
These are meant as cache for the register contents. I also thought about storing the default values (ex. for comparison), but according to the datasheets (ex. Kabylake) some registers have values like this 44000x00h. I think x is a placeholder, but I have no idea what that means.
File util/inteltool/gpio_test.h:
Patch Set #10, Line 24: .name
What do we gain from repeating the field identifiers in each […]
I think the brackets make it more messy. Using the field identifiers I tried to improve the overview over the columns.
We also can use spaces/tabs.
Patch Set #10, Line 26: FUNC(3, "ESPI_IO0") } },
Personally, I prefer more condensed tables where a row fits a single line. […]
I am fine with both.
To view, visit change 31634. To unsubscribe, or for help writing mail filters, visit settings.