Attention is currently required from: Felix Singer, Martin L Roth, Paul Menzel, Angel Pons, Elyes Haouas.
View Change
1 comment:
Patchset:
Patch Set #20:
FYI, one thing clang-format seems to handle poorly is consecutive macros that have indented bit definitions. For example, after running `clang-format-15 -i -style=file` with this patch applied, I see things like:
-#define MSR_FEATURE_CONFIG 0x13c
-#define FEATURE_CONFIG_LOCK BIT(0)
+#define MSR_FEATURE_CONFIG 0x13c
+#define FEATURE_CONFIG_LOCK BIT(0)
In this case the indentation before FEATURE_CONFIG_LOCK makes it more obvious that it's a field within MSR_FEATURE_CONFIG. I'm not sure if there's a way to make clang-format follow that convention, but thought it's worth mentioning.
To view, visit change 64779. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibec6b6d47c58c393dc28f91cbf109f3e87f935bf
Gerrit-Change-Number: 64779
Gerrit-PatchSet: 20
Gerrit-Owner: Elyes Haouas <ehaouas@noos.fr>
Gerrit-Reviewer: Felix Singer <felixsinger@posteo.net>
Gerrit-Reviewer: Jonathan Zhang <jon.zhixiong.zhang@gmail.com>
Gerrit-Reviewer: Martin L Roth <gaumless@gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus@gmail.com>
Gerrit-CC: David Hendricks <david.hendricks@gmail.com>
Gerrit-CC: Maximilian Brune <maximilian.brune@9elements.com>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Felix Singer <felixsinger@posteo.net>
Gerrit-Attention: Martin L Roth <gaumless@gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Attention: Elyes Haouas <ehaouas@noos.fr>
Gerrit-Comment-Date: Wed, 01 Mar 2023 07:06:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment