Felix Singer would like Nico Huber to review this change.

View Change

soc/intel/cnl: Fix `PcieClkSrcUsage` setting

Remove unnecessary for-loop because the setting gets overwritten with
memcpy afterwards.

Change-Id: Idb2192e68e29ae53fcdd0775ac7fd6cea2930a0e
Signed-off-by: Nico Huber <nico.huber@secunet.com>
---
M src/soc/intel/cannonlake/fsp_params.c
1 file changed, 0 insertions(+), 4 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/39795/1

diff --git a/src/soc/intel/cannonlake/fsp_params.c b/src/soc/intel/cannonlake/fsp_params.c
index 4634806..bbacfc1 100644
--- a/src/soc/intel/cannonlake/fsp_params.c
+++ b/src/soc/intel/cannonlake/fsp_params.c
@@ -320,10 +320,6 @@
 		params->PchCnviMode = 0;
 #endif
 	/* PCI Express */
-	for (i = 0; i < ARRAY_SIZE(config->PcieClkSrcUsage); i++) {
-		if (config->PcieClkSrcUsage[i] == 0)
-			config->PcieClkSrcUsage[i] = PCIE_CLK_NOTUSED;
-	}
 	memcpy(params->PcieClkSrcUsage, config->PcieClkSrcUsage,
 	       sizeof(config->PcieClkSrcUsage));
 	memcpy(params->PcieClkSrcClkReq, config->PcieClkSrcClkReq,

To view, visit change 39795. To unsubscribe, or for help writing mail filters, visit settings.