3 comments:
Patch Set #3, Line 50: void spd_set_name(uint8_t spd[], char part_name[]);
nit: it's functionally the same, but you declare it here as `char part_name[]` but in the .c file it's `char *part_name`.
Patch Set #3, Line 140: static bool spd_part_name_overridden = false;
all statics are cleared to 0 (bss section).
Also this variable seems redundant; you could just check if` spd_dram_part_name != 0` to know if the override has been called;
Patch Set #3, Line 141: spd_set_name
suggestion: `spd_override_name`
To view, visit change 45459. To unsubscribe, or for help writing mail filters, visit settings.