Attention is currently required from: Dmitry Ponamorev, Mariusz Szafrański, Suresh Bellampalli, Vanessa Eusebio, Michal Motyl, Kyösti Mälkki, Patrick Rudolph, King Sumo.
Patch set 26:Code-Review +1
5 comments:
File src/mainboard/teleplatforms/D4E4S16P8/Kconfig:
select SUPPORT_CPU_UCODE_IN_CBFS
select FSP_CAR
select CPU_INTEL_COMMON
select PARALLEL_MP_AP_WORK
select SOC_INTEL_COMMON_BLOCK_FAST_SPI
Shouldn't these be selected by DNV-NS Kconfig?
File src/mainboard/teleplatforms/D4E4S16P8/acpi/mainboard_pci_irqs.asl:
Patch Set #21, Line 3: board specific
Well it's coupled with devicetree. […]
Ack
File src/mainboard/teleplatforms/D4E4S16P8/devicetree.cb:
This device number is suspicious, isn't this downstream of the root port?
File src/mainboard/teleplatforms/D4E4S16P8/ramstage.c:
Patch Set #21, Line 26: SMBUS_IO_BASE
This is ramstage, smbus_base() is romstage. […]
Ack
Patch Set #21, Line 28: (tmp < 0x20 || tmp > 0x7f)
Not sure if it looks like what you intended?
Looks good, thanks!
To view, visit change 57194. To unsubscribe, or for help writing mail filters, visit settings.