Is this just a WIP patch? Or do you intend to push this in? As you mentioned in the commit message, this doesn't really do anything. Is there any benefit of pushing it in? I would prefer having a driver better fleshed out than pushing stub change in. Also, it is not very clear as to why drivers/i2c/generic is not a good choice for this device.

View Change

To view, visit change 37904. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1716e6f186a097b309504762017b98747972547c
Gerrit-Change-Number: 37904
Gerrit-PatchSet: 2
Gerrit-Owner: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Furquan Shaikh <furquan@google.com>
Gerrit-Comment-Date: Mon, 23 Dec 2019 10:30:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment