Attention is currently required from: Patrick Rudolph.

View Change

5 comments:

• File src/soc/intel/skylake/chip.c:

  • Patch Set #2, Line 536: if (CONFIG(RUN_FSP_GOP) && dev && dev->enabled && \

    Avoid unnecessary line continuations

• File src/soc/intel/skylake/romstage/fsp_params.c:

  • Patch Set #2, Line 118: igd = 0x8086 == pci_read_config16(SA_DEVFN_IGD, PCI_VENDOR_ID);

    Comparisons should place the constant on the right side of the test

• File src/soc/intel/skylake/romstage/systemagent.c:

  • Patch Set #2, Line 32: if (igd_dev && igd_dev->enabled && pci_read_config16(SA_DEVFN_IGD, PCI_VENDOR_ID) == 0x8086) {

    line over 96 characters

  • Patch Set #2, Line 32: if (igd_dev && igd_dev->enabled && pci_read_config16(SA_DEVFN_IGD, PCI_VENDOR_ID) == 0x8086) {

    braces {} are not necessary for single statement blocks

• File src/soc/intel/skylake/systemagent.c:

  • Patch Set #2, Line 49: if (igd_dev && igd_dev->enabled && pci_read_config16(igd_dev, PCI_VENDOR_ID) == 0x8086)

    line over 96 characters

To view, visit change 51332. To unsubscribe, or for help writing mail filters, visit settings.