Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson.
Felix Held has uploaded this change for review.
soc/amd/common/include/acpimmio: drop 16 and 32 bit PM2 access functions
The PM2 ACPIMMIO region should only be accessed with 8 bit accesses.
Using 16 or 32 bit read accesses will return the data from the first
byte for all 2 or 4 bytes and 16 or 32 bit write accesses will result in
only the first byte being written which is both unexpected behavior.
Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Change-Id: I5ace50d3b81b5bf3ea3b10aa02f25c58a6ea99b9
---
M src/soc/amd/common/block/include/amdblocks/acpimmio.h
1 file changed, 0 insertions(+), 20 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/61625/1
diff --git a/src/soc/amd/common/block/include/amdblocks/acpimmio.h b/src/soc/amd/common/block/include/amdblocks/acpimmio.h
index ae86730..2d632f6 100644
--- a/src/soc/amd/common/block/include/amdblocks/acpimmio.h
+++ b/src/soc/amd/common/block/include/amdblocks/acpimmio.h
@@ -198,31 +198,11 @@
return read8(acpimmio_pmio2 + reg);
}
-static inline uint16_t pm2_read16(uint8_t reg)
-{
- return read16(acpimmio_pmio2 + reg);
-}
-
-static inline uint32_t pm2_read32(uint8_t reg)
-{
- return read32(acpimmio_pmio2 + reg);
-}
-
static inline void pm2_write8(uint8_t reg, uint8_t value)
{
write8(acpimmio_pmio2 + reg, value);
}
-static inline void pm2_write16(uint8_t reg, uint16_t value)
-{
- write16(acpimmio_pmio2 + reg, value);
-}
-
-static inline void pm2_write32(uint8_t reg, uint32_t value)
-{
- write32(acpimmio_pmio2 + reg, value);
-}
-
static inline uint8_t acpi_read8(uint8_t reg)
{
return read8(acpimmio_acpi + reg);
To view, visit change 61625. To unsubscribe, or for help writing mail filters, visit settings.