5 comments:
File src/soc/intel/apollolake/cse.c:
remove extra line.
Done
File src/soc/intel/cannonlake/me.c:
remove extra line.
Done
File src/soc/intel/common/block/cse/cse.c:
you mean error returns 0 and success returns -1? that strange should that be opposite ? […]
Done
File src/soc/intel/common/block/include/intelblocks/cse.h:
Patch Set #15, Line 57: * Returns 0 on failure 1 on success.
you are doing something else in the function
Done
File src/soc/intel/skylake/me.c:
Patch Set #15, Line 282: intel_me_status
are you also plan to move this into common code ? if yes then why don't you do it here in this CL so […]
No plans to move this code to common code as the HFSTS1 register bit defination is different for each socket
To view, visit change 35225. To unsubscribe, or for help writing mail filters, visit settings.