2 comments:
File src/soc/amd/cezanne/bootblock.c:
Patch Set #2, Line 59: ALIGN_DOWN(top_mem.lo, 8*MiB)
only works if this is a power of 2
i'm not sure what should only work when it's a power of 2. the second parameter of ALIGN_DOWN is a power of two and the parameter of var_mtrr_set doesn't seem to need to be a power of 2.
Patch Set #2, Line 60: CONFIG_ROM_SIZE
reuse CAR_CACHE_ROM_SIZE to make sure it's a power of 2?
the symbols needed by CAR_CACHE_ROM_SIZE are likely not available, since this soc doesn't use CAR. I also haven't seen a non power of two flash configuration on AMD like there might be on Intel systems. from the datasheet, i'd expect this region to always be 16MByte
To view, visit change 48517. To unsubscribe, or for help writing mail filters, visit settings.