View Change
1 comment:
Commit Message:
Patch Set #1, Line 9: There's no reason
Yes, see the follow-up commits. Among others, I want to use it on bootblock and romstage as well. […]
IMO, HWM configuration is best done in the ramstage via devicetree. Any
particular reason to do it early?
I've peeked ahead and the code looks almost ready for that, all you'd
need is a little shim between dt and your functions in some .init function.
To view, visit change 42130. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I103a4ea4cef24844d382854c9358bbb37d229e04
Gerrit-Change-Number: 42130
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: HAOUAS Elyes <ehaouas@noos.fr>
Gerrit-CC: Nico Huber <nico.h@gmx.de>
Gerrit-Comment-Date: Sun, 07 Jun 2020 11:06:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com>
Comment-In-Reply-To: HAOUAS Elyes <ehaouas@noos.fr>
Gerrit-MessageType: comment