Attention is currently required from: Hung-Te Lin, Paul Menzel, Ruihai Zhou, cong yang.
View Change
2 comments:
Commit Message:
Patch Set #11, Line 10:
Please document the datasheet name and revision.
already mentioned in CB:78956
Patch Set #11, Line 12: TEST=Boot to firmware screen
How is the boottime affected?
FW screen won't be enabled in ChromeOS's normal boot. So it won't impact the boot time.
To view, visit change 78957. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0a04f062f81c543d38716d7ff185b5633c1aa3a9
Gerrit-Change-Number: 78957
Gerrit-PatchSet: 11
Gerrit-Owner: Ruihai Zhou <zhouruihai@huaqin.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte@chromium.org>
Gerrit-Reviewer: Yidi Lin <yidilin@google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Reviewer: cong yang <yangcong5@huaqin.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Hung-Te Lin <hungte@chromium.org>
Gerrit-Attention: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Ruihai Zhou <zhouruihai@huaqin.corp-partner.google.com>
Gerrit-Attention: cong yang <yangcong5@huaqin.corp-partner.google.com>
Gerrit-Comment-Date: Thu, 11 Jan 2024 16:54:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter@mailbox.org>
Gerrit-MessageType: comment