Attention is currently required from: Furquan Shaikh, Francois Toguo Fotso, Subrata Banik, Kane Chen, Patrick Rudolph, Karthik Ramasubramanian.
9 comments:
File src/soc/intel/common/block/crashlog/Kconfig:
Patch Set #6, Line 4: Enables crashlog PCI drivers which collect crashlog data on boot,
I believe more than SoC, there should be a flexibility given to mainboards or platform users to choo […]
Done
Patch Set #6, Line 8: SOC_INTEL_COMMON_BLOCK_CRASHLOG_PMC_TRIGGER_ON_RESET
WDYT about this name, do the Kconfig need to be explicit about whether PMC is the one who is trigger […]
Done
Patch Set #6, Line 17: SOC_INTEL_COMMON_BLOCK_CRASHLOG_DISABLE
Ideally yes, knowing the this PCI device has two major purpose. […]
SG
File src/soc/intel/common/block/crashlog/pmc_crashlog.c:
Patch Set #6, Line 30: discovery_response
Why is this here and not in crashlog_lib. […]
Done
bool crashlog_copy_pmc_records(void *dest, size_t size)
{
const struct cbmem_entry *entry;
entry = cbmem_entry_find(CBMEM_ID_PMC_CRASHLOG);
if (!entry || !cbmem_entry_size(entry))
return false;
memcpy(dest, cbmem_entry_start(entry), MIN(size, cbmem_entry_size(entry)));
return true;
}
Is this function really required? The caller is already making calls to `cbmem_entry_find()` and `cb […]
Ack
if (res == NULL)
res = &placeholder;
Not for this CL, but looks like we have at least one more instance (cse_eop. […]
Ack
Patch Set #6, Line 92: Note: The SRAM area is automatically cleared on G3 entry by the PMC
Is this note added to indicate that the crash log data would be empty when booting from G3?
yes
Patch Set #6, Line 330: if (!is_dev_enabled(dev))
Maybe like this ? […]
Done
if (!is_dev_enabled(dev))
return;
`init` shouldn't be called if device is disabled. So, this check is redundant.
Done
To view, visit change 57684. To unsubscribe, or for help writing mail filters, visit settings.