8 comments:
File src/soc/mediatek/mt8192/dramc_pi_basic_api.c:
Patch Set #41, Line 3844: while
Can we use wait_us?
i use wait_ms, timeout: 10 seconds.
One space after "="
Ack
No need for initialization.
Ack
File src/soc/mediatek/mt8192/dramc_pi_main.c:
Patch Set #41, Line 17: static void get_dram_info_after_cal(struct ddr_cali *cali)
If cali->density is the only thing modified in this function, why not return max_density? […]
Actually, get dram info contains vendor id, density and so on.
As you noticed, here, we only save the density for use, maybe other information will be saved for future use.
so we want to keep "get_dram_info*" function name, is it ok?
g
Ack
Patch Set #41, Line 52: default
If this indicates an error, please print an error message.
Ack
u
Ack
Patch Set #41, Line 134: only need do once for
Only need to do once to
Ack
To view, visit change 44712. To unsubscribe, or for help writing mail filters, visit settings.