Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30912 )
Change subject: autoport: Generate a libgfxinit template ......................................................................
Patch Set 1: Code-Review+1
(2 comments)
https://review.coreboot.org/#/c/30912/1/util/autoport/main.go File util/autoport/main.go:
https://review.coreboot.org/#/c/30912/1/util/autoport/main.go@751 PS1, Line 751: KconfigBool["MAINBOARD_HAS_LIBGFXINIT"] = true : KconfigComment["MAINBOARD_HAS_LIBGFXINIT"] = "FIXME: check this" : AddRAMStageFile("gma-mainboard.ads", "CONFIG_MAINBOARD_USE_LIBGFXINIT") Maybe out of the scope of this patch, but would autodetecting whether the IGD is enabled help?
https://review.coreboot.org/#/c/30912/1/util/autoport/main.go@914 PS1, Line 914: ports Somewhere nearby: -- FIXME: check this