View Change

1 comment:

• File src/mainboard/google/volteer/variants/baseboard/devicetree.cb:

  • Patch Set #2, Line 214: register "power_limits_config[POWER_LIMITS_U_2_CORE]" = "{

    How are these power limits determined?

    i) Are they same for all mainboards using a particular CPU?
    ii) Are these dependent on mainboard design?

    If it is i), why not put these values in SoC directly. If it is ii), shouldn't this go in overridetree.cb for that variant?

    From the details on the bug it looks like it is probably (i). Or are you putting this here because they need to be tuned later on based on each OEM design?

To view, visit change 43607. To unsubscribe, or for help writing mail filters, visit settings.