Patch Set 1:

Unfortunately, the OS can't really use the spi controller for anything because there's no hardware arbitration. Any reads to the SPI ROM's memory address will automatically get sent out over the spi bus to the Firmware ROM, messing up any transactions if there were another device on the SPI bus.

Because of that, I think it's better just not to even tell the OS about the spi controller.

oh, you might have a point there. I'll add a -1, so that it won't accidentally get merged for now; not sure when I'll get around to have a close look into this

Patch set 1:Code-Review -1

View Change

To view, visit change 47826. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If1bc33dd264327f9119e1019700510ba9acca810
Gerrit-Change-Number: 47826
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk@gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd@gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Sat, 21 Nov 2020 19:20:41 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment