I kinda went out of order in the patch stack because I wanted to focus on the devicetree view first.
5 comments:
File src/mainboard/google/volteer/variants/baseboard/devicetree.cb:
register "policies.enabled.passive" = "1"
register "policies.enabled.critical" = "1"
register "policies.enabled.active" = "1"
could these be auto-detected by non-zero values in the different policy structures?
Patch Set #5, Line 261: .source=DPTF_CPU, .target=DPTF_CPU, .temp=95, .period=5000}"
you could define a macro for generating these:
DPTF_PASSIVE(CPU, CPU, 95, 5000) //or something similar...
Patch Set #5, Line 284: 28000
might be able to use "28 * MSECS_PER_SEC" in here
Patch Set #5, Line 294: Fan Performance Control (Percent, Speed, Noise, Power)
Not sure if you want to go there but it seems like this table could be calculated with some input values like number of steps and some fan characteristics. It looks like most boards use the same table for noise/power even if they change the speed values which makes me wonder if/how DPTF actually uses those values.
this seems to be hardcoded in the ASL, maybe it should just default to '2' and allow overriding?
To view, visit change 41895. To unsubscribe, or for help writing mail filters, visit settings.