12 comments:
Patch Set #4, Line 9: replace
To me, "replace X with Y" is "s/X/Y" in vim-speech. […]
Done
File src/southbridge/amd/agesa/hudson/smbus_spd.c:
Patch Set #3, Line 20: /* warning: Porting.h includes an open #pragma pack(1) */
#pragma cursed
Left a comment and AGESA.h include in the same place where Porting.h was
File src/southbridge/amd/agesa/hudson/smbus_spd.c:
Patch Set #4, Line 26: readSmbusByteData
These things might need a rename
Did some renaming from FoObAr to foo_bar
Patch Set #4, Line 27: int offset)
But this still fits in 96 chars?
Still, I'm not used to it.
Patch Set #4, Line 43: limit = rdtscll() + 2000000000 / 10;
This is reinventing the wheel, there should be a timer API somewhere.
There is in lib/timer.h. Even the wait_us/ms macro looks pretty nice for this use, however, I'm bad at using conditions in macros.
if (status == 2)
status = 0;
return status;
this could even be: […]
Done
Please pick this up (should be on the previous line)
Done
Patch Set #4, Line 112: printk(BIOS_SPEW, "-------------READING SPD-----------\n");
Good thing nobody sees this by default (I hope)
It should be in RAM still land available in cbmem
Patch Set #4, Line 139: ioBase
This variable should be lowercase
Done
File src/southbridge/amd/pi/hudson/smbus_spd.c:
Patch Set #3, Line 21: /* warning: Porting.h includes an open #pragma pack(1) */
Keep comment
Done
Patch Set #3, Line 23: #include <northbridge/amd/agesa/dimmSpd.h>
pi
Done
File src/southbridge/amd/pi/hudson/smbus_spd.c:
I am saying that src/southbridge/amd/{agesa,pi}/hudson/smbus_spd.c seem to be the same thing.
yes it is (except the dimmSpd.h include)
To view, visit change 38163. To unsubscribe, or for help writing mail filters, visit settings.