Attention is currently required from: Cliff Huang, Lance Zhao, Paul Menzel, Tim Wawrzynczak.
View Change
2 comments:
Commit Message:
Patch Set #3, Line 7: acpi: acpi_device_write_dsd_gpio(): Fix returned index by incrementing value
too long. Please shorten.
Done
Patch Set #3, Line 11: The error was introduced in the commit making it public.
You should add the original commit hash here, please check the comment rule in coreboot. […]
Done
To view, visit change 82088. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7a3eb89633aaebebc8bd98ac6126c578fda23839
Gerrit-Change-Number: 82088
Gerrit-PatchSet: 5
Gerrit-Owner: Jianeng Ceng <cengjianeng@huaqin.corp-partner.google.com>
Gerrit-Reviewer: Cliff Huang <cliff.huang@intel.com>
Gerrit-Reviewer: Dolan Liu <liuyong5@huaqin.corp-partner.google.com>
Gerrit-Reviewer: Eric Lai <ericllai@google.com>
Gerrit-Reviewer: Kapil Porwal <kapilporwal@google.com>
Gerrit-Reviewer: Lance Zhao <lance.zhao@gmail.com>
Gerrit-Reviewer: Tim Wawrzynczak <inforichland@gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-CC: Subrata Banik <subratabanik@google.com>
Gerrit-Attention: Lance Zhao <lance.zhao@gmail.com>
Gerrit-Attention: Cliff Huang <cliff.huang@intel.com>
Gerrit-Attention: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Tim Wawrzynczak <inforichland@gmail.com>
Gerrit-Comment-Date: Fri, 26 Apr 2024 03:21:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Lai <ericllai@google.com>
Gerrit-MessageType: comment