6 Jan
2023
6 Jan
'23
5:38 p.m.
Attention is currently required from: Jamie Ryu, Subrata Banik, Eric Lai, Usha P.
Harsha B R has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71168 )
Change subject: mb/intel/mtlrvp: Configure USB devices for MTL-RVP ......................................................................
Patch Set 5:
(1 comment)
File src/mainboard/intel/mtlrvp/variants/baseboard/mtlrvp_p/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/71168/comment/538ead77_4e9f5c03 PS5, Line 31: "USB3_PORT_DEFAULT(OC0)" # M.2 WWAN
u don't need OC configuration for WWAN
usb3_port[0] is Type-A by default. M.2 WWAN is possible only with rework. So thought of not skipping OC here. However usb2_ports[7] and usb2_ports[8] we have OC_CKIP
--
To view, visit https://review.coreboot.org/c/coreboot/+/71168
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If1a0c31b7bf0f3fc06f039ad76b0cdd41f7cdd90
Gerrit-Change-Number: 71168
Gerrit-PatchSet: 5
Gerrit-Owner: Harsha B R harsha.b.r@intel.com
Gerrit-Reviewer: Eric Lai eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Jamie Ryu jamie.m.ryu@intel.com
Gerrit-Reviewer: Sridhar Siricilla sridhar.siricilla@intel.com
Gerrit-Reviewer: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: Usha P usha.p@intel.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Balaji Manigandan balaji.manigandan@intel.com
Gerrit-CC: Haribalaraman Ramasubramanian haribalaraman.r@intel.com
Gerrit-Attention: Jamie Ryu jamie.m.ryu@intel.com
Gerrit-Attention: Subrata Banik subratabanik@google.com
Gerrit-Attention: Eric Lai eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Usha P usha.p@intel.com
Gerrit-Comment-Date: Fri, 06 Jan 2023 17:38:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik subratabanik@google.com
Gerrit-MessageType: comment